Skip to content

Feat: provide jnml command that will use the bundled jar #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

sanjayankur31
Copy link
Member

Works fine, but it'll be good to see if it breaks any workflows---omv for example should just find this wrapper now and work with it, but we should just test it out a little.

PyNeuroML will provide a `jnml` command too, which will use the bundled
jNeuroML jar file. Note that to use another jnml, such as one from the
jNeuroML release tar, one can simply either use the full path, or modify
the $PATH etc. variables that are available on most systems.
@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Jun 12, 2025
@sanjayankur31 sanjayankur31 added the S: ready for review Status: ready for review label Jun 12, 2025
This ensures that the output matches what running `jnml` from the
jNeuroML repo would show.

This is required for omv etc. to continue functioning as is.
@sanjayankur31 sanjayankur31 moved this from 🆕 New to 🔖 Ready in NeuroML backlog Jun 12, 2025
sanjayankur31 added a commit to OpenSourceBrain/osb-model-validation that referenced this pull request Jun 12, 2025
@sanjayankur31
Copy link
Member Author

This seems to work fine, along with OpenSourceBrain/osb-model-validation#138

Should I merge and cut a release @pgleeson ?

So that other things depending on it, like omv, get the right exit code
to process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: ready for review Status: ready for review T: enhancement Type: enhancement
Projects
Status: 🔖 Ready
Development

Successfully merging this pull request may close these issues.

1 participant